release-20.2: sql: fix UPSERT with columns after partial index PUT and DEL columns #61489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug in UPSERT execution that was caused by the incorrect assumption that there are never columns following the partial index PUT and DEL columns in the mutation's input. I was unable to reproduce this bug for INSERTs or DELETEs. However, I updated the execution code for both out of caution. The logic for both no longer makes the same assumption that partial index PUT and DEL columns will be the last columns in the input. Fixes cockroachdb#61414 Release justification: This is a low-risk fix for a bug causing UPSERT statements to err when executed on tables with partial indexes. Release note (bug fix): A bug which caused UPSERT and INSERT..ON CONFLICT..DO UPDATE statements to fail on tables with both partial indexes and foreign key references has been fixed. This bug has been present since version 20.2.0.
|
This change is |
RaduBerinde
approved these changes
Mar 4, 2021
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @rytaft)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/2 commits from #61416.
/cc @cockroachdb/release
sql: fix UPSERT with columns after partial index PUT and DEL columns
This commit fixes a bug in UPSERT execution that was caused by the
incorrect assumption that there are never columns following the partial
index PUT and DEL columns in the mutation's input.
I was unable to reproduce this bug for INSERTs or DELETEs. However, I
updated the execution code for both out of caution. The logic for both
no longer makes the same assumption that partial index PUT and DEL
columns will be the last columns in the input.
Fixes #61414
Release justification: This is a low-risk fix for a bug causing UPSERT
statements to err when executed on tables with partial indexes.
Release note (bug fix): A bug which caused UPSERT and INSERT..ON
CONFLICT..DO UPDATE statements to fail on tables with both partial
indexes and foreign key references has been fixed. This bug has been
present since version 20.2.0.
ccl: add tests for implicitly partitioned partial unqiue indexes
Release justification: This is a test-only change.
Release note: None