Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-20.1: importccl: fix bug when rolling back imports with no timestamp #61481

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

pbardea
Copy link
Contributor

@pbardea pbardea commented Mar 4, 2021

Backport 1/1 commits from #59723.

/cc @cockroachdb/release


If a timestamp for the import was not chosen, there should be no
ingested data to rollback. However, we do want to continue with the
IMPORT cleanup to bring any OFFLINE tables back to PUBLIC.

Fixes #59481.

Release note (bug fix): Fixes a bug where some import failures would
cause tables to stay OFFLINE, when they should have been brough back to
PUBLIC.

If a timestamp for the import was not chosen, there should be no
ingested data to rollback. However, we do want to continue with the
IMPORT cleanup to bring any OFFLINE tables back to PUBLIC.

Release note (bug fix): Fixes a bug where some import failures would
cause tables to stay OFFLINE, when they should have been brough back to
PUBLIC.
@pbardea pbardea requested a review from dt March 4, 2021 16:32
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@pbardea
Copy link
Contributor Author

pbardea commented Mar 9, 2021

Friendly ping to resurface, along with #61480.

@pbardea
Copy link
Contributor Author

pbardea commented Mar 9, 2021

TFTR!

@pbardea pbardea merged commit 75c6f0a into cockroachdb:release-20.1 Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants