cli: ensure that --log is recognized for non-server commands
#61232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
knz
force-pushed
the
20210228-cli-log
branch
from
3eedbd7 to
4abd8bf
Compare
aaron-crl
approved these changes
Feb 28, 2021
There was a problem hiding this comment.
Reviewable status:
|
thank you! bors r=aaron-crl |
|
Build failed: |
knz
force-pushed
the
20210228-cli-log
branch
2 times, most recently
from
bc3a43e to
a37c21f
Compare
Release justification: bug fixes and low-risk updates to new functionality Release note (bug fix): The non-server `cockroach` commands now recognize the new `--log` flag properly. This had been broken unadvertently in one of the earlier 21.1 alpha releases.
knz
force-pushed
the
20210228-cli-log
branch
from
a37c21f to
d1cd456
Compare
|
bors r=aaron-crl |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @taroface
Release justification: bug fixes and low-risk updates to new functionality
Release note (bug fix): The non-server
cockroachcommands nowrecognize the new
--logflag properly. This had been brokenunadvertently in one of the earlier 21.1 alpha releases.