storage: add a scan benchmark with resolved intents #61198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jbowens
approved these changes
Mar 1, 2021
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @itsbilal, @nvanbenschoten, @petermattis, and @sumeerbhola)
pkg/storage/bench_test.go, line 277 at r1 (raw file):
b, makeSettingsForSeparatedIntents(false, sep)) numFlushedVersions := (percentFlushed * numVersions) / 100 setupKeysWithIntent(b, eng, numVersions, numFlushedVersions, true)
nit:
true /* resolveAll */
It stresses the case where many versions were written transactionally and all were resolved. This is the benchmark mentioned in cockroachdb/pebble#1067 to justify the Pebble seek noop optimization. Release justification: Non-production code change that adds a benchmark. Release note: None
sumeerbhola
commented
Mar 1, 2021
There was a problem hiding this comment.
TFTR!
Reviewable status:
pkg/storage/bench_test.go, line 277 at r1 (raw file):
Previously, jbowens (Jackson Owens) wrote…
nit:
true /* resolveAll */
Done
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It stresses the case where many versions were written
transactionally and all were resolved.
This is the benchmark mentioned in
cockroachdb/pebble#1067
to justify the Pebble seek noop optimization.
Release justification: Non-production code change that
adds a benchmark.
Release note: None