release-20.1: lease: fix lease retention bug for tables taken offline #61144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tables can temporarily be taken offline, either permanently or temporarily. For example, executing a DROP TABLE statement will take a table offline permanently, and an IMPORT INTO will take a table offline only for the duration of the import and will bring it online again afterward. Previously, the lease manager would not distinguish between those two cases and would behave as if the table was gone forever. As a result any lease acquired after the table came back online would always be dropped upon dereferencing. Although this behavior is valid, it is inefficient, hence this patch. Fixes cockroachdb#57834. Release note: None
|
This change is |
|
Notice that this differs from #61140 in one important respect, in that the test is not included here, because it uses constructs that weren't around yet in 20.1. My understanding is that this change is low-risk enough & well-tested in more recent releases that this isn't a huge deal. |
ajwerner
approved these changes
Feb 26, 2021
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @postamar)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tables can temporarily be taken offline, either permanently or
temporarily. For example, executing a DROP TABLE statement will take
a table offline permanently, and an IMPORT INTO will take a table
offline only for the duration of the import and will bring it online
again afterward.
Previously, the lease manager would not distinguish between those two
cases and would behave as if the table was gone forever. As a result any
lease acquired after the table came back online would always be dropped
upon dereferencing. Although this behavior is valid, it is inefficient,
hence this patch.
Fixes #57834.
Release note: None