Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builtins: implement ST_MakePoint and ST_MakePointM #61105

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

andyyang890
Copy link
Collaborator

This patch implements the geometry builtins ST_MakePoint
and ST_MakePointM.

Resolves #60857.
Resolves #60858.
Resolves #60859.

Release justification: low-risk update to new functionality
Release note (sql change): The geometry builtins ST_MakePoint
and ST_MakePointM have been implemented and provide a mechanism
for easily creating new points.

@andyyang890 andyyang890 requested review from rafiss and otan February 25, 2021 02:39
@cockroach-teamcity
Copy link
Member

This change is Reviewable

pkg/geo/geo.go Outdated Show resolved Hide resolved
pkg/sql/logictest/testdata/logic_test/geospatial_zm Outdated Show resolved Hide resolved
pkg/sql/sem/builtins/geo_builtins.go Show resolved Hide resolved
This patch implements the geometry builtins `ST_MakePoint`
and `ST_MakePointM`.

Release justification: low-risk update to new functionality
Release note (sql change): The geometry builtins `ST_MakePoint`
and `ST_MakePointM` have been implemented and provide a mechanism
for easily creating new points.
@andyyang890
Copy link
Collaborator Author

TFTR! bors r=otan,rafiss

@andyyang890
Copy link
Collaborator Author

oops it has to be on a different line

bors r=otan,rafiss

@craig
Copy link
Contributor

craig bot commented Feb 25, 2021

Build succeeded:

@craig craig bot merged commit 4d24f8a into cockroachdb:master Feb 25, 2021
@andyyang890 andyyang890 deleted the st_makepoint_funcs branch February 25, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants