server: bug fix to correct path checks for existing certificates prior to generation #61101
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @aaron-crl and @itsbilal)
pkg/server/auto_tls_init.go, line 94 at r1 (raw file):
} // Both key and cert should now be populated
nit: period at end of sentence
pkg/server/auto_tls_init.go, line 145 at r1 (raw file):
// Cert exists but key doesn't, this is an error. return errors.Wrapf(err, "failed to load service certificate key for %s expected key at %s",
nit: use %q instead of %s so that paths containing spaces are more clearly readable
…r to generation I erred in my use of os.Stat and no checks were correct. I've refactored the read/write functions to perform these checks themselves. This also improves our resliency against races between time of check and time of use for cert/key file paths. Release justification: bug fix to enable proper automatic generation of certificates Release note: None
aaron-crl
force-pushed
the
aaron-crl_secure-init
branch
from
3f1260a to
598fc1a
Compare
There was a problem hiding this comment.
Reviewable status:
pkg/server/auto_tls_init.go, line 94 at r1 (raw file):
Previously, knz (kena) wrote…
nit: period at end of sentence
Done.
pkg/server/auto_tls_init.go, line 145 at r1 (raw file):
Previously, knz (kena) wrote…
nit: use
%qinstead of%sso that paths containing spaces are more clearly readable
Done here and elsewhere in file.
|
bors r+ |
|
Build succeeded: |
I erred in my use of os.Stat and no exists checks were correct. I've refactored the read/write
functions to perform these checks themselves. This also improves our resiliency against
races between time of check and time of use for cert/key file paths.
Part of #60632
Release justification: bug fix to enable proper automatic generation of certificates
Release note: None