roachtest: make splits/largerange more aggressive #61043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Here are some pretty cool graphs of this roachtest in action around the point where we let the single 32GB range start splitting and rebalancing:
|
irfansharif
approved these changes
Feb 24, 2021
|
I think the test just cuts all load once the dataset is loaded in and waits for splitting. The test doesn't currently wait for rebalancing to complete, though. I'm going to add that. |
nvanbenschoten
force-pushed
the
nvanbenschoten/largerangeSplits
branch
5 times, most recently
from
5c9a816 to
975377d
Compare
This commit addresses a TODO by extending the splits/largerange roachtest to run on a 6 node cluster. This extension means that the test will begin performing rebalancing once splits begin, which should stress the behavior of streaming snapshots. If we were to ever hold one of these snapshots in-memory in its entirety, the test would have a bad time. Release justification: testing only
nvanbenschoten
force-pushed
the
nvanbenschoten/largerangeSplits
branch
from
975377d to
4725b5b
Compare
|
bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses a TODO by extending the splits/largerange roachtest to run
on a 6 node cluster. This extension means that the test will begin performing
rebalancing once splits begin, which should stress the behavior of streaming
snapshots. If we were to ever hold one of these snapshots in-memory in its
entirety, the test would have a bad time.
Release justification: testing only