Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geo/wkt: add line and pos numbers to WKT parser syntax errors #60971

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

andyyang890
Copy link
Collaborator

This patch enhances the WKT parser to show line and position
numbers in syntax error messages.

Refs: #53091

Release note: None

@andyyang890 andyyang890 requested a review from otan February 23, 2021 02:49
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@otan otan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE(1)

This patch enhances the WKT parser to show line and position
numbers in syntax error messages.

Release note: None
@andyyang890
Copy link
Collaborator Author

bors r=otan

@craig
Copy link
Contributor

craig bot commented Feb 23, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Feb 23, 2021

Build succeeded:

@craig craig bot merged commit 2572200 into cockroachdb:master Feb 23, 2021
@andyyang890 andyyang890 deleted the wkt_err_linenums branch February 23, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants