Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: enable required release justifications for stability period #60967

Merged
merged 1 commit into from
Feb 24, 2021
Merged

build: enable required release justifications for stability period #60967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/teamcity-check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

# Set this to 1 to require a "release justification" note in the commit message
# or the PR description.
require_justification=0
require_justification=1

set -euo pipefail

Expand Down
2 changes: 1 addition & 1 deletion githooks/commit-msg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ IFS='
notes=($($grep -iE '^release note' "$1"))

# Set this to 1 to require a release justification note.
require_justification=0
require_justification=1
justification=($($grep -iE '^release justification: \S+' "$1"))

IFS=$saveIFS
Expand Down
2 changes: 1 addition & 1 deletion githooks/prepare-commit-msg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#
# Prepare the commit message by adding a release note.

require_justification=0
require_justification=1
set -euo pipefail

if [[ "${2-}" = "message" ]]; then
Expand Down