kvserver: fix TestBadRequest #60964
Merged
kvserver: fix TestBadRequest #60964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
andreimatei
reviewed
Feb 22, 2021
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @lunevalex and @nvanbenschoten)
pkg/kv/kvclient/kvcoord/dist_sender_server_test.go, line 1521 at r1 (raw file):
// To make the last check fail we need to search the replica that starts at // KeyMin i.e. typically its Range(1).
it's
Fixes cockroachdb#51795 This test was originally written when the test infra started up with a single range. This commit updates the logic to work with any config. To make the last error fire, we need to contain the delete span to a single range that starts at KeyMin. Release note: None
lunevalex
force-pushed
the
alex/fix-test-bad-request
branch
from
84e2dfb to
697fa61
Compare
|
TFTR! bors r+ |
|
Build failed: |
|
bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51795
This test was originally written when the test infra started up with a
single range. This commit updates the logic to work with any config.
To make the last error fire, we need to contain the delete span to
a single range that starts at KeyMin.
Release note: None