opt: add partition info to the opt catalog #60818
Conversation
|
This change is |
rytaft
force-pushed
the
locality-opt2
branch
from
dccc2fb to
9a0ddeb
Compare
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @mgartner and @rytaft)
pkg/sql/opt/cat/index.go, line 190 at r1 (raw file):
// [ /us/seattle\x00 - ] // PartitionByListPrefixes() []tree.Datums
Shouldn't we remove this now? We can get the same by joining the prefixes for all the Partitions, no?
Prior to this commit, the opt catalog did not include zone information or prefixes specific to each partition of an index. This commit adds this information since it will be necessary to support locality optimized search in a future commit. Informs cockroachdb#55185 Release note: None
rytaft
force-pushed
the
locality-opt2
branch
from
9a0ddeb to
9678713
Compare
There was a problem hiding this comment.
Reviewable status:
pkg/sql/opt/cat/index.go, line 190 at r1 (raw file):
Previously, RaduBerinde wrote…
Shouldn't we remove this now? We can get the same by joining the prefixes for all the Partitions, no?
Done. Also moved some of this comment down.
There was a problem hiding this comment.
Reviewed 3 of 13 files at r1, 11 of 11 files at r2.
Reviewable status:
|
TFTR! bors r+ |
|
Build succeeded: |
Prior to this commit, the opt catalog did not include zone information
or prefixes specific to each partition of an index. This commit adds this
information since it will be necessary to support locality optimized
search in a future commit.
Informs #55185
Release note: None