Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql,telemetry: update tests to check for scrubbed stmts #60777

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Feb 19, 2021

This also removes the GetUnscrubbedReportingStats function, since it
would be a mistake to ever report unscrubbed stats.

Made these improvements while investigating #60722

Release note: None

@rafiss rafiss requested a review from a team as a code owner February 19, 2021 06:07
@cockroach-teamcity
Copy link
Member

This change is Reviewable

This also removes the GetUnscrubbedReportingStats function, since it
would be a mistake to ever report unscrubbed stats.

Release note: None
@rafiss rafiss force-pushed the test-telemetry-scrub branch from 5399e0f to 71d3149 Compare February 19, 2021 16:29
@rafiss rafiss requested review from knz, a team and arulajmani February 19, 2021 16:30
Copy link
Collaborator

@arulajmani arulajmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @knz)

@rafiss
Copy link
Collaborator Author

rafiss commented Feb 22, 2021

tftr!

bors r=arulajmani

@craig
Copy link
Contributor

craig bot commented Feb 22, 2021

Build succeeded:

@craig craig bot merged commit ce8488c into cockroachdb:master Feb 22, 2021
@rafiss rafiss deleted the test-telemetry-scrub branch February 24, 2021 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants