sql,opt: add cluster and session settings for locality optimized search #60771
Conversation
|
This change is |
rytaft
force-pushed
the
locality-opt
branch
4 times, most recently
from
1158740 to
8369cda
Compare
There was a problem hiding this comment.
[nit] locality_optimized_search sounds very general (e.g. one could reasonably assume it encompasses the locality-sensitive index selection). Maybe locality_optimized_partitioned_index_scan?
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @mgartner and @rytaft)
pkg/sql/exec_util.go, line 296 at r1 (raw file):
var localityOptimizedSearchMode = settings.RegisterBoolSetting( "sql.defaults.locality_optimized_search.enabled", "default value for locality_optimized_search session setting;"+
[nit] "disables locality optimizer search by default" is confusing (sounds like that's what happens if we set it to true). I'd just leave it out.
There was a problem hiding this comment.
TFTR!
[nit] locality_optimized_search sounds very general (e.g. one could reasonably assume it encompasses the locality-sensitive index selection). Maybe locality_optimized_partitioned_index_scan?
Done.
Reviewable status:
pkg/sql/exec_util.go, line 296 at r1 (raw file):
Previously, RaduBerinde wrote…
[nit] "disables locality optimizer search by default" is confusing (sounds like that's what happens if we set it to true). I'd just leave it out.
Done. I also added a bit more info about what it actually does (for documentation purposes).
There was a problem hiding this comment.
Reviewable status:
|
bors r- |
|
Canceled. |
This commit adds a new session setting locality_optimized_partitioned_index_scan and corresponding cluster default setting sql.defaults.locality_optimized_partitioned_index_scan.enabled. In future commits, these settings will be used to enable or disable locality optimized search. If enabled, the optimizer will try to plan scans and lookup joins in which local nodes are searched for matching rows before remote nodes, in the hope that the execution engine can avoid visiting remote nodes. Informs cockroachdb#55185 Release note (sql change): Added a new session setting locality_optimized_partitioned_index_scan and corresponding cluster default setting sql.defaults.locality_optimized_partitioned_index_scan.enabled. Both are currently disabled by default, and are currently unused. In the future, these settings will be used to enable or disable locality optimized search. If enabled, the optimizer will try to search locally for rows in REGIONAL BY ROW tables before searching remote nodes.
|
bors r+ |
|
Build failed (retrying...): |
There was a problem hiding this comment.
Reviewed 5 of 10 files at r1, 5 of 5 files at r2.
Reviewable status:
|
Build succeeded: |
This commit adds a new session setting
locality_optimized_partitioned_index_scanand corresponding cluster default setting
sql.defaults.locality_optimized_partitioned_index_scan.enabled. In futurecommits, these settings will be used to enable or disable locality optimized
search. If enabled, the optimizer will try to plan scans and lookup joins in
which local nodes are searched for matching rows before remote nodes,
in the hope that the execution engine can avoid visiting remote nodes.
Informs #55185
Release note (sql change): Added a new session setting
locality_optimized_partitioned_index_scan and corresponding cluster default
setting sql.defaults.locality_optimized_partitioned_index_scan.enabled.
Both are currently disabled by default, and are currently unused. In the
future, these settings will be used to enable or disable locality
optimized search. If enabled, the optimizer will try to search locally
for rows in REGIONAL BY ROW tables before searching remote nodes.