Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: remove experimental setting for virtual columns #60748

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

RaduBerinde
Copy link
Member

Informs #57608.

Release note (sql change): CockroachDB now supports VIRTUAL computed
columns (as opposed to STORED). These are computed columns that are
not stored in the primary index and are recomputed as necessary.

@RaduBerinde RaduBerinde requested a review from a team as a code owner February 18, 2021 19:58
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Release note (sql change): CockroachDB now supports VIRTUAL computed
columns (as opposed to STORED). These are computed columns that are
not stored in the primary index and are recomputed as necessary.
Copy link
Collaborator

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RaduBerinde
Copy link
Member Author

bors r+

craig bot pushed a commit that referenced this pull request Feb 19, 2021
60748: sql: remove experimental setting for virtual columns r=RaduBerinde a=RaduBerinde

Informs #57608.

Release note (sql change): CockroachDB now supports VIRTUAL computed
columns (as opposed to STORED). These are computed columns that are
not stored in the primary index and are recomputed as necessary.

Co-authored-by: Radu Berinde <[email protected]>
@craig
Copy link
Contributor

craig bot commented Feb 19, 2021

Build failed:

@RaduBerinde
Copy link
Member Author

bors r+

@craig
Copy link
Contributor

craig bot commented Feb 19, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Feb 19, 2021

Build succeeded:

@craig craig bot merged commit 0e7cfdb into cockroachdb:master Feb 19, 2021
@RaduBerinde RaduBerinde deleted the virt-no-exp branch February 24, 2021 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants