opt: add test constraining partial index on virtual column #60601
Conversation
|
This change is |
| # the predicate. | ||
| # TODO(mgartner): Teach indexConstraintCtx.simplifyFilter to remove b=140 from | ||
| # the remaining filters after the index constraint is built. This will eliminate | ||
| # the unnecessary index-join and select expressions. |
There was a problem hiding this comment.
I added this limitation to #57608 to track.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @mgartner and @RaduBerinde)
pkg/sql/opt/xform/testdata/rules/select, line 1726 at r1 (raw file):
# Regression test for #55387. GenerateConstrainedScans should not reduce the # input filters when proving partial index implication.
Did you mean to remove this comment?
mgartner
force-pushed
the
constrained-partial-index-virtual
branch
from
28f268f to
169afb8
Compare
There was a problem hiding this comment.
Reviewable status:
pkg/sql/opt/xform/testdata/rules/select, line 1726 at r1 (raw file):
Previously, rytaft (Rebecca Taft) wrote…
Did you mean to remove this comment?
Nope! Fixed.
There was a problem hiding this comment.
Reviewable status:
pkg/sql/opt/xform/testdata/rules/select, line 1736 at r2 (raw file):
# the unnecessary index-join and select expressions. opt SELECT k FROM virtual WHERE c = 150
Can you add a test with WHERE b = 140?
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:
mgartner
force-pushed
the
constrained-partial-index-virtual
branch
from
169afb8 to
7c3275f
Compare
There was a problem hiding this comment.
Reviewable status:
pkg/sql/opt/xform/testdata/rules/select, line 1736 at r2 (raw file):
Previously, RaduBerinde wrote…
Can you add a test with WHERE b = 140?
Done. It suffers from the same limitation of simplifyFilter.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3.
Reviewable status:
mgartner
force-pushed
the
constrained-partial-index-virtual
branch
2 times, most recently
from
6a5c99c to
09134da
Compare
|
bors r+ |
|
Build failed (retrying...): |
|
Build failed: |
No code changes were necessary in order to generate a constrained scan for a partial index on a virtual column. Release note: None
mgartner
force-pushed
the
constrained-partial-index-virtual
branch
from
09134da to
2d2c867
Compare
|
bors r+ |
|
Build succeeded: |
No code changes were necessary in order to generate a constrained scan
for a partial index on a virtual column.
Release note: None