-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: use go runtime task groups to measure CPU/RAM usage per session #60588
Draft
knz
wants to merge
1
commit into
cockroachdb:master
Choose a base branch
from
knz:20210215-task-groups
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knz
force-pushed
the
20210215-task-groups
branch
2 times, most recently
from
February 22, 2021 16:31
02e1372
to
c03b3bc
Compare
knz
force-pushed
the
20210215-task-groups
branch
2 times, most recently
from
May 17, 2021 15:40
b66431e
to
de09b24
Compare
knz
force-pushed
the
20210215-task-groups
branch
from
June 21, 2021 13:47
de09b24
to
e2d950a
Compare
knz
force-pushed
the
20210215-task-groups
branch
from
June 28, 2021 14:35
e2d950a
to
974ab3a
Compare
knz
changed the title
sql: use go runtime task groups to measure CPU usage per session
sql: use go runtime task groups to measure CPU/RAM usage per session
Jun 28, 2021
knz
force-pushed
the
20210215-task-groups
branch
2 times, most recently
from
June 30, 2021 12:07
1916670
to
53a399a
Compare
cc @cockroachdb/sql-observability @cockroachdb/obs-inf-prs can one of you folk help? I'm modifying the session proto to add some field and getting some build errors:
This somewhere in |
oh nevermind, I should learn how to read the error message. I was able to fix it. Thanks |
This uses the experimental task group API (see related RFC) to measure CPU/RAM usage separately per SQL session. The experimental task group API is available in this custom branch of the Go runtime: https://github.com/cockroachdb/go/commits/crdb-fixes The interface for the API in the new library go-plus (github.com/cockroachdb/go-plus) ensures that the code runs without error even when the custom go runtime is not being used. Note that this implementation does not yet collect CPU/RAM usage on other nodes when a session runs distributed queries. Release note: None
knz
force-pushed
the
20210215-task-groups
branch
from
June 30, 2021 12:11
53a399a
to
a50bb8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the experimental task group API (see related RFC)
to measure CPU/RAM usage separately per SQL session.
The experimental task group API is available in this custom
branch of the Go runtime:
cockroachdb/go@crdb-fixes (commits)
The interface for the API in the new library go-plus
(github.com/cockroachdb/go-plus) ensures that the code runs without
error even when the custom go runtime is not being used.
Note that this implementation does not yet collect CPU/RAM usage on other
nodes when a session runs distributed queries.