Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geo/wkt: simplify parser grammar and improve error messages #60561

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

andyyang890
Copy link
Collaborator

This patch simplifies the yacc grammar for the WKT parser
and also improves the error messages for mixed dimensionality
problems.

Refs: #53091

Release note: None

@andyyang890 andyyang890 requested a review from otan February 14, 2021 05:30
@cockroach-teamcity
Copy link
Member

This change is Reviewable

pkg/geo/wkt/lex.go Outdated Show resolved Hide resolved
pkg/geo/wkt/lex.go Outdated Show resolved Hide resolved
pkg/geo/wkt/lex.go Outdated Show resolved Hide resolved
@blathers-crl blathers-crl bot requested a review from otan February 16, 2021 18:35
This patch simplifies the yacc grammar for the WKT parser
and also improves the error messages for mixed dimensionality
problems.

Release note: None
@andyyang890
Copy link
Collaborator Author

bors r=otan

@craig
Copy link
Contributor

craig bot commented Feb 16, 2021

Build succeeded:

@craig craig bot merged commit 959750d into cockroachdb:master Feb 16, 2021
@andyyang890 andyyang890 deleted the wkt_parse_simplify branch February 16, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants