kvserver: unify two request flags #60548
Conversation
|
This change is |
pkg/roachpb/batch.go
Outdated
| func (ba *BatchRequest) IsUnsplittable() bool { | ||
| return ba.hasFlag(isUnsplittable) | ||
| } | ||
|
|
||
| // ConsultsTimestampCache returns whether the request must consult |
There was a problem hiding this comment.
Why keep BatchRequest.ConsultsTimestampCache() but not ConsultsTimestampCache(Request)? I'd either keep both or remove both.
andreimatei
force-pushed
the
small.unify-isintent-consultstscache
branch
from
8fbc4f6 to
456c53f
Compare
| @@ -207,7 +207,7 @@ func (r *Replica) tryReproposeWithNewLeaseIndex( | |||
| defer untrack(ctx, 0, 0, 0) // covers all error paths below | |||
| // The ConsultsTimestampCache condition matches the similar logic for caring | |||
There was a problem hiding this comment.
This comment now needs an update.
isIntentWrite and consultsTSCache are always used in conjunction. It seems that they must always be used in conjunction. Remove consultsTSCache. Release note: None
andreimatei
force-pushed
the
small.unify-isintent-consultstscache
branch
from
456c53f to
b956057
Compare
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @nvanbenschoten)
pkg/kv/kvserver/replica_application_result.go, line 208 at r2 (raw file):
Previously, nvanbenschoten (Nathan VanBenschoten) wrote…
This comment now needs an update.
done
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3.
Reviewable status:
There was a problem hiding this comment.
bors r+
Reviewable status:
|
Build succeeded: |
isIntentWrite and consultsTSCache are always used in conjunction. It
seems that they must always be used in conjunction. Remove
consultsTSCache.
Release note: None