sql: ensure type schema change cleanup job is resilient to retries #60495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
@otan I think the testing knob belongs in this commit, as I think we may wanna backport this thing to 20.2. |
otan
reviewed
Feb 11, 2021
| "descriptor %d not found for type change job; assuming it was dropped, and exiting", | ||
| tc.typeID, | ||
| ) | ||
| case !isPermanentSchemaChangeError(rollbackErr): |
There was a problem hiding this comment.
i'm not sure i trust this function enough to not leave dangling references but i have not enough experience with it ;)
LGTM is LGT-schema!
Previously if the type schema changer ran into a non-permanent error, it wouldn't retry transparently. Instead, manual cleanup would be required. This patch fixes this behavior. This patch also adds a testing knob, `RunAfterOnFailOrCancel` to test the afformentioned bug. Fixes cockroachdb#60489 Release note (bug fix): Previosly, retryable errors in the cleanup phase of the type schema changer wouldn't be retried automatically in the background. This is now fixed.
arulajmani
force-pushed
the
type-changer-retryable
branch
from
b6b6170 to
755fa25
Compare
thoszhang
approved these changes
Feb 16, 2021
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @arulajmani)
|
bors r=lucy-zhang,otan |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if the type schema changer ran into a non-permanent error,
it wouldn't retry transparently. Instead, manual cleanup would be
required. This patch fixes this behavior.
This patch also adds a testing knob,
RunAfterOnFailOrCancelto testthe afformentioned bug.
Fixes #60489
Release note (bug fix): Previosly, retryable errors in the cleanup
phase of the type schema changer wouldn't be retried automatically
in the background. This is now fixed.