Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logic: fix flakey logic test #60439

Closed

Conversation

ajwerner
Copy link
Contributor

Since #53842 we write an initial liveness record with a zero timestamp.
This sometimes shows up as the following flake.

    logic.go:2283:

        testdata/logic_test/crdb_internal:356: SELECT node_id, regexp_replace(epoch::string, '^\d+$', '<epoch>') as epoch, regexp_replace(expiration, '^\d+\.\d+,\d+$', '<timestamp>') as expiration, draining, decommissioning, membership FROM crdb_internal.gossip_liveness WHERE node_id = 1
        expected:
            node_id  epoch  expiration    draining  decommissioning     membership
            1        <epoch>      <timestamp>   false     false               active

        but found (query options: "colnames") :
            node_id  epoch    expiration  draining  decommissioning  membership
            1        <epoch>  0,0         false     false            active

Release note: None

Since cockroachdb#53842 we write an initial liveness record with a zero timestamp.
This sometimes shows up as the following flake.

```
    logic.go:2283:

        testdata/logic_test/crdb_internal:356: SELECT node_id, regexp_replace(epoch::string, '^\d+$', '<epoch>') as epoch, regexp_replace(expiration, '^\d+\.\d+,\d+$', '<timestamp>') as expiration, draining, decommissioning, membership FROM crdb_internal.gossip_liveness WHERE node_id = 1
        expected:
            node_id  epoch  expiration    draining  decommissioning     membership
            1        <epoch>      <timestamp>   false     false               active

        but found (query options: "colnames") :
            node_id  epoch    expiration  draining  decommissioning  membership
            1        <epoch>  0,0         false     false            active
```

Release note: None
@ajwerner ajwerner requested a review from irfansharif February 10, 2021 19:21
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@ajwerner
Copy link
Contributor Author

fixed by 095b7a4

@ajwerner ajwerner closed this Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants