sql: fix a race in the internal executor #60425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent change to make the internal executor streaming introduced a race between `initConnEx` returning (and, thus, assigning a stmtBuf value) and the connExecutor's goroutine being spawn up. As a result, the assumption of the callbacks that the stmtBuf is non-nil might not be satisfied. This commit fixes the issue by creating the objects in question before `initConnEx` is called (which is also before the connExecutor goroutine starts). Release note: None
|
This change is |
RaduBerinde
approved these changes
Feb 10, 2021
|
TFTR! bors r+ p=9999 single on |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent change to make the internal executor streaming introduced
a race between
initConnExreturning (and, thus, assigning a stmtBufvalue) and the connExecutor's goroutine being spawn up. As a result, the
assumption of the callbacks that the stmtBuf is non-nil might not be
satisfied. This commit fixes the issue by creating the objects in
question before
initConnExis called (which is also before theconnExecutor goroutine starts).
Fixes: #60423.
Release note: None