roachtest: Use internal IP address for kafka-auth test certs #60255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For these tests, kafka and cockroach live on the same machine, so we use the InternalIP to create the CHANGEFEED. Previously, however, we were creating certificates with subject alternative names that used the external IP, causing connection issues. While here, I've also removed the advertised listeners config which we aren't really using for these tests. Release note: None
|
This change is |
This was referenced Feb 9, 2021
HonoreDB
approved these changes
Feb 15, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @aayushshah15)
|
bors r=HonoreDB |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For these tests, kafka and cockroach live on the same machine, so we
use the InternalIP to create the CHANGEFEED. Previously, however, we
were creating certificates with subject alternative names that used
the external IP, causing connection issues.
While here, I've also removed the advertised listeners config which we
aren't really using for these tests.
Release note: None