build: cross-compile when building roachtest tools #60149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rickystewart
force-pushed
the
ssd/roachtest-fix
branch
from
60c98d8 to
e01edb0
Compare
The roachtest, workload, and roachprod tools might need to run on different machines than the builder when running the roachtests. By using mkrelease, we ensure that theses are built using the cross-compilation environment that supports older glibc versions. This avoids us having to keep the builder image in line with other images we might use for testing. Release note: None
rickystewart
force-pushed
the
ssd/roachtest-fix
branch
from
e01edb0 to
110fa0d
Compare
otan
approved these changes
Feb 9, 2021
rickystewart
force-pushed
the
ssd/roachtest-fix
branch
2 times, most recently
from
4166a9d to
110fa0d
Compare
|
bors r+ |
|
Build failed: |
|
bors r+ |
|
Build failed (retrying...): |
craig bot
pushed a commit
that referenced
this pull request
Feb 10, 2021
60149: build: cross-compile when building roachtest tools r=rickystewart a=stevendanna The roachtest, workload, and roachprod tools might need to run on machines with older glibcs than the builder when running the roachtests. By using mkrelease, we ensure that theses are built using the cross-compilation environment that supports older glibc versions. This avoids us having to keep the builder image in line with other images we might use for testing. Release note: None Co-authored-by: Steven Danna <[email protected]>
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The roachtest, workload, and roachprod tools might need to run on machines
with older glibcs than the builder when running the roachtests. By
using mkrelease, we ensure that theses are built using the
cross-compilation environment that supports older glibc versions. This
avoids us having to keep the builder image in line with other images
we might use for testing.
Release note: None