-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Add tooltips to the visualization wrapper #6006
Conversation
3f3f275
to
30e0b52
Compare
49e8093
to
722a3a8
Compare
Reviewed 5 of 9 files at r1, 4 of 4 files at r2. ui/styl/modules/palette.styl, line 62 [r2] (raw file): ui/styl/partials/layout.styl, line 579 [r2] (raw file): ui/styl/partials/layout.styl, line 610 [r2] (raw file): Comments from Reviewable |
, suggestions provided on how to clean up the CSS a bit. I would like for the tooltips to eventually position themselves more intelligently (for example, based on mouse cursor position); explicitly specifying '.left/.right' or doing it based on hierarchy is fine for now, though (although I would suggest picking one approach or the other, if possible). Review status: all files reviewed at latest revision, 3 unresolved discussions. Comments from Reviewable |
722a3a8
to
20cf214
Compare
Cleaned up the CSS to just use the hierarchy as suggested. I'll hold off on doing something more intelligent until I see if there's a react component that can handle the various issues involved with this instead (eg detecting if a tooltip would go off the page and repositioning it.) Review status: 7 of 9 files reviewed at latest revision, 3 unresolved discussions. ui/styl/modules/palette.styl, line 62 [r2] (raw file): ui/styl/partials/layout.styl, line 579 [r2] (raw file): ui/styl/partials/layout.styl, line 610 [r2] (raw file): Comments from Reviewable |
90cdd9e
to
1b45fbb
Compare
Review status: 7 of 9 files reviewed at latest revision, 11 unresolved discussions. ui/ts/pages/cluster.ts, line 100 [r4] (raw file): ui/ts/pages/cluster.ts, line 103 [r4] (raw file): "You are using ~3GB of ~80GB storage capacity across all nodes." If it needs to be static, we could try: "The estimated percentage of total storage capacity currently in use." ui/ts/pages/cluster.ts, line 129 [r4] (raw file): "The estimated time between query request and response, in milliseconds." Not sure how to explain the percentiles here. Need to work with someone on that. ui/ts/pages/cluster.ts, line 142 [r4] (raw file): ui/ts/pages/cluster.ts, line 151 [r4] (raw file): ui/ts/pages/cluster.ts, line 158 [r4] (raw file): ui/ts/pages/cluster.ts, line 170 [r4] (raw file): ui/ts/pages/cluster.ts, line 178 [r4] (raw file): Comments from Reviewable |
ui/ts/pages/cluster.ts, line 170 [r4] (raw file): Comments from Reviewable |
@jseldess Here are all the current tooltips. |
LGTM, @maxlang. Should we add tooltips for other tabs in this PR, or would you rather do that in a separate PR? |
1b45fbb
to
61be7da
Compare
This change is