opt: move fraction function from statistics code to selectivity #60012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
mgartner
approved these changes
Feb 8, 2021
There was a problem hiding this comment.
Nice!
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @angelazxu)
pkg/sql/opt/props/selectivity.go, line 38 at r1 (raw file):
// MakeSelectivityFromFraction calculates selectivity as a fraction of a and b // if a is less than b and returns 1 otherwise.
[nit] "... and returns OneSelectivity otherwise."
pkg/sql/opt/props/selectivity_test.go, line 67 at r1 (raw file):
test(MakeSelectivityFromFraction(1.5, 1), s(1)) test(MakeSelectivityFromFraction(1, 0), s(1)) test(MakeSelectivityFromFraction(0, 0), s(1))
Why use s(1) three times here instead of OneSelectivity?
The fraction function in the statistics builder code was only being used to construct Selectivity, used inside the MakeSelectivity method. This change moves the logic from the fraction function into the code for Selectivity. It is an additional clean-up to cockroachdb#59413, to get rid of direct numerical operations on Selectivity. Fixes: cockroachdb#53860 Release note: None
angelazxu
force-pushed
the
selectivity_fraction
branch
from
8039e77 to
1b88044
Compare
angelazxu
commented
Feb 8, 2021
There was a problem hiding this comment.
Reviewable status:
pkg/sql/opt/props/selectivity_test.go, line 67 at r1 (raw file):
Previously, mgartner (Marcus Gartner) wrote…
Why use
s(1)three times here instead ofOneSelectivity?
fixed!
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fraction function in the statistics builder code was only being used to
construct Selectivity, used inside the MakeSelectivity method.
This change moves the logic from the fraction function into the code for
Selectivity. It is an additional clean-up to #59413, to get rid of direct
numerical operations on Selectivity.
Fixes: #53860
Release note: None