sql: include invalid type descriptors in crdb_internal.invalid_objects #59978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `crdb_internal.invalid_objects` only validated table descriptors. This patch adds type descriptors to the list of objects that are validated. As this table is used to validate all descriptors after logic tests run, going forward, validation inconsistencies will be checked for and reported after logic test runs. Release note (sql change): `crdb_internal.invalid_objects` also includes invalid type descriptors.
|
This change is |
otan
approved these changes
Feb 8, 2021
|
TFTR! bors r=otan |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
crdb_internal.invalid_objectsonly validated tabledescriptors. This patch adds type descriptors to the list of objects
that are validated. As this table is used to validate all descriptors
after logic tests run, going forward, validation inconsistencies will be
checked for and reported after logic test runs.
Release note (sql change):
crdb_internal.invalid_objectsalsoincludes invalid type descriptors.