backupccl: add an owner column behind the WITH PRIVILEGES option #59732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
pbardea
reviewed
Feb 2, 2021
|
These changes look good! I just had a question about the comment in the test. Also, since this change has user-facing effects, we should add a release note in the commit message. Something like: |
Elliebababa
force-pushed
the
show_backup_owner
branch
2 times, most recently
from
a8511c0 to
251b442
Compare
pbardea
reviewed
Feb 3, 2021
Previously, when users perform RESTORE, they are ignorant of the original owner. This PR gives ownership data as a column behind privileges. Resolves: cockroachdb#57906. Release note(sql change): Update SHOW BACKUP ... WITH PRIVILEGES to display ownership information of objects in the backup.
Elliebababa
force-pushed
the
show_backup_owner
branch
from
251b442 to
8aa486f
Compare
|
TFTR! bors r=pbardea |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when users perform RESTORE, they are ignorant of the original owner.
This PR gives ownership data as a column behind privileges.
Resolves: #57906.
Release note: None.