Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geo/wkt: implement parser for points with Z and M dimensions #59690

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

andyyang890
Copy link
Collaborator

This patch adds a parser that is capable of parsing WKT
representations of points with Z and M dimensions.

Refs: #53091

Release note: None

@andyyang890 andyyang890 requested review from otan and a team February 2, 2021 03:51
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@otan otan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! some small nits

pkg/geo/wkt/lex.go Outdated Show resolved Hide resolved
pkg/geo/wkt/lex.go Outdated Show resolved Hide resolved
pkg/geo/wkt/lex.go Outdated Show resolved Hide resolved
pkg/geo/wkt/wkt.go Outdated Show resolved Hide resolved
pkg/geo/wkt/lex_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@otan otan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm accepting this to unblock you in the morning, and there are only nits!
i trust you to fix them up :)

@andyyang890 andyyang890 force-pushed the wkt_parse_point branch 3 times, most recently from cad596f to f2b1b13 Compare February 2, 2021 05:22
This patch adds a parser that is capable of parsing WKT
representations of points with Z and M dimensions.

Release note: None
@andyyang890
Copy link
Collaborator Author

bors r=otan

@craig
Copy link
Contributor

craig bot commented Feb 2, 2021

Build succeeded:

@craig craig bot merged commit a0236ac into cockroachdb:master Feb 2, 2021
@andyyang890 andyyang890 deleted the wkt_parse_point branch February 2, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants