sql: omit NOTICE about indexes not being partitioned for PARTITION ALL BY

[otan]

We previously would print a notice specifying that non-partitioned
indexes on partitioned tables may not be performant - however, this
notice does not apply for PARTITION ALL BY tables as they will be
implicitly added for all indexes.

Release note: None

[cockroach-teamcity]

This change is 

[ajstorm]

Nit: "as they will be implicitly added for all indexes." -> "as all of their indexes will be automatically partitioned"

Just nits -

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @otan)

---

pkg/sql/create_index.go, line 422 at r1 (raw file):

	if n.n.PartitionByIndex == nil &&
		n.tableDesc.GetPrimaryIndex().GetPartitioning().NumColumns > 0 &&
		!n.tableDesc.IsPartitionAllBy() {

Nit: Can we add a comment here explaining why we exclude IsPartitionAllBy() here. It makes sense if you're familiar with PARTITION ALL, but if not, a small hint would help readability.

---

pkg/sql/create_table.go, line 254 at r1 (raw file):

		for _, def := range n.n.Defs {
			if d, ok := def.(*tree.IndexTableDef); ok {
				if d.PartitionByIndex == nil && !n.n.PartitionByTable.All {

Nit: Comment here too.

[otan]

thanks

bors r=ajstorm

[craig]

Build succeeded:

• GitHub CI (Cockroach)