Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add licensing info to README #59490

Merged
merged 3 commits into from
Feb 18, 2021
Merged

add licensing info to README #59490

merged 3 commits into from
Feb 18, 2021

Conversation

gemma-shay
Copy link
Contributor

@gemma-shay gemma-shay commented Jan 27, 2021

Added a section on licensing info.
Links to the new Licensing doc (#9338) will not work yet, so will wait to merge until they are up.
Closes cockroachdb/docs#7441

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jan 27, 2021

CLA assistant check
All committers have signed the CLA.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@bdarnell bdarnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worry that this is just enough information to be confusing - maybe we should just say that the software is licensed under a combination of the BSL and CCL and link out to the full docs for more details?

If we do want more of a summary here I think it's important to emphasize that there are basically two paths: core/free and enterprise. Both editions use a combination of BSL and CCL (the third option, BSL-only, should be discussed only in relation to what happens when the BSL converts to APL)

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @gemma-shay and @piyush-singh)


README.md, line 115 at r1 (raw file):

- [Cockroach Community License (Paid)](https://www.cockroachlabs.com/docs/stable/licensing.html#ccl-paid)

Core features released up to and including version 19.1 are licensed under [Apache 2.0](https://www.cockroachlabs.com/docs/stable/licensing.html#apache). After version 19.1, core features are licensed under the BSL for three years before converting to the Apache 2.0 license.

Maybe say "Beginning with version 19.2" instead of "After 19.1"?

The second sentence uses "core features" without defining it.


README.md, line 117 at r1 (raw file):

Core features released up to and including version 19.1 are licensed under [Apache 2.0](https://www.cockroachlabs.com/docs/stable/licensing.html#apache). After version 19.1, core features are licensed under the BSL for three years before converting to the Apache 2.0 license.

BSL features are free to use and the source code is available, but users may not use CockroachDB as a service without an agreement with Cockroach Labs. Outside of this usage, BSL features will continue to be free to use and source code will continue to be available.

Be more specific about what's not allowed: "but users may not offer CockroachDB as a commercial database service without an agreement..." The second sentence seems redundant to me.

Copy link
Contributor

@bdarnell bdarnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @gemma-shay and @piyush-singh)

Copy link

@piyush-singh piyush-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @gemma-shay)

@lnhsingh
Copy link
Contributor

bors r=bdarnell

@lnhsingh
Copy link
Contributor

bors r-

@craig
Copy link
Contributor

craig bot commented Feb 18, 2021

Canceled.

@gemma-shay
Copy link
Contributor Author

bors r=bdarnell

@craig
Copy link
Contributor

craig bot commented Feb 18, 2021

🔒 Permission denied

Existing reviewers: click here to make gemma-shay a reviewer

@lnhsingh
Copy link
Contributor

bors r=bdarnell

@craig
Copy link
Contributor

craig bot commented Feb 18, 2021

Build succeeded:

@craig craig bot merged commit d67d6cc into master Feb 18, 2021
@jordanlewis jordanlewis deleted the readme-licensing branch April 15, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License summary in main repo README.md
5 participants