-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add licensing info to README #59490
add licensing info to README #59490
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I worry that this is just enough information to be confusing - maybe we should just say that the software is licensed under a combination of the BSL and CCL and link out to the full docs for more details?
If we do want more of a summary here I think it's important to emphasize that there are basically two paths: core/free and enterprise. Both editions use a combination of BSL and CCL (the third option, BSL-only, should be discussed only in relation to what happens when the BSL converts to APL)
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @gemma-shay and @piyush-singh)
README.md, line 115 at r1 (raw file):
- [Cockroach Community License (Paid)](https://www.cockroachlabs.com/docs/stable/licensing.html#ccl-paid) Core features released up to and including version 19.1 are licensed under [Apache 2.0](https://www.cockroachlabs.com/docs/stable/licensing.html#apache). After version 19.1, core features are licensed under the BSL for three years before converting to the Apache 2.0 license.
Maybe say "Beginning with version 19.2" instead of "After 19.1"?
The second sentence uses "core features" without defining it.
README.md, line 117 at r1 (raw file):
Core features released up to and including version 19.1 are licensed under [Apache 2.0](https://www.cockroachlabs.com/docs/stable/licensing.html#apache). After version 19.1, core features are licensed under the BSL for three years before converting to the Apache 2.0 license. BSL features are free to use and the source code is available, but users may not use CockroachDB as a service without an agreement with Cockroach Labs. Outside of this usage, BSL features will continue to be free to use and source code will continue to be available.
Be more specific about what's not allowed: "but users may not offer CockroachDB as a commercial database service without an agreement..." The second sentence seems redundant to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @gemma-shay and @piyush-singh)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @gemma-shay)
bors r=bdarnell |
bors r- |
Canceled. |
bors r=bdarnell |
🔒 Permission denied Existing reviewers: click here to make gemma-shay a reviewer |
bors r=bdarnell |
Build succeeded: |
Added a section on licensing info.
Links to the new Licensing doc (#9338) will not work yet, so will wait to merge until they are up.
Closes cockroachdb/docs#7441