*:upgrade vendored pgconn to v1.8.0 #59408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
gaoxk
force-pushed
the
upgrade-pgconn
branch
2 times, most recently
from
c2ef24e to
422879b
Compare
jbowens
approved these changes
Jan 26, 2021
There was a problem hiding this comment.
Thanks for upgrading this! Looks like we'll need to update pkg/sql/pgwire/testdata/pgtest/notice to include the "SeverityUnlocalized" field that was added to pgproto3.NoticeResponse.
Reviewable status:
complete! 1 of 0 LGTMs obtained
jbowens
force-pushed
the
upgrade-pgconn
branch
from
dc73ab0 to
b320f97
Compare
gaoxk
force-pushed
the
upgrade-pgconn
branch
2 times, most recently
from
a3b21a3 to
4356769
Compare
jbowens
force-pushed
the
upgrade-pgconn
branch
5 times, most recently
from
47c9024 to
41ea997
Compare
Release note: none
jbowens
force-pushed
the
upgrade-pgconn
branch
from
41ea997 to
45704de
Compare
|
bors r+ |
|
Already running a review |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old version of pgconn asynchronously cancelled requests to the server. However, .connect synchronously closes connections in responses to errors. This causes race conditions for goroutine leaks.
The newer pgconn synchronously closes connections to the server, ideally eliminating this race condition. See jackc/pgconn@340bfec
Release note (general change): Upgrade to v1.8.0
pgconnto patch potential race condition errors.