Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpcutil: Return true from RequestDidNotStart on open circuit breaker error #59309

Merged
merged 1 commit into from
Jan 25, 2021
Merged

grpcutil: Return true from RequestDidNotStart on open circuit breaker error #59309

merged 1 commit into from
Jan 25, 2021

Conversation

mneverov
Copy link
Contributor

grpcutil: Return true from RequestDidNotStart on open circuit breaker error

Previously, the gRPC error check returned false on open circuit breaker error
that led to the request retries. Returning true instead should prevent
needless retries.

Fixes: #55869

Release note: None

@blathers-crl
Copy link

blathers-crl bot commented Jan 22, 2021

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

I have added a few people who may be able to assist in reviewing:

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added O-community Originated from the community X-blathers-triaged blathers was able to find an owner labels Jan 22, 2021
@blathers-crl blathers-crl bot requested review from darinpp and lunevalex January 22, 2021 19:00
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@tbg tbg self-requested a review January 22, 2021 19:44
@tbg
Copy link
Member

tbg commented Jan 22, 2021

Thanks Max! I'll take a look next week.

@mneverov
grpcutil: Return true from RequestDidNotStart on open circuit breaker…
8385a69 
… error

Previously, the gRPC error check returned false on open circuit breaker error
that led to the request retries. Returning true instead, should prevent
needless retries.

Fixes: cockroachdb#55869

Release note: None
@mneverov mneverov force-pushed the no_retries_on_breaker_open branch from 456f651 to 8385a69 Compare January 23, 2021 08:25
@blathers-crl
Copy link

blathers-crl bot commented Jan 23, 2021

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

tbg
tbg approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@tbg tbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:, thanks Max!

bors r+

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @darinpp and @lunevalex)

@tbg
Copy link
Member

tbg commented Jan 25, 2021

Btw, I just reached out on the community slack. Just mentioning this in case you don't get notified.

@craig
Copy link
Contributor

craig bot commented Jan 25, 2021

Build succeeded:

@craig craig bot merged commit 8efa63d into cockroachdb:master Jan 25, 2021
@nvanbenschoten nvanbenschoten mentioned this pull request Oct 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbg tbg tbg approved these changes

@darinpp darinpp Awaiting requested review from darinpp

@lunevalex lunevalex Awaiting requested review from lunevalex

Assignees
No one assigned
Labels
O-community Originated from the community X-blathers-triaged blathers was able to find an owner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kvserver: modify RequestDidNotStart to return true when circuit.ErrBreakerOpen
3 participants
@mneverov @cockroach-teamcity @tbg