importccl: account for the RowSource return constraint #59115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...in the import processor. The contract of `RowSource.Next` requires that at most one of the return values will be non-empty. This wasn't the case here, and caused opaque failures in cockroachdb#58897. cockroachdb#58897 tries to enable background tracing by default, which for us means that the trailing meta can be non-empty (they'll contain span recordings). That behaviour ends up tickling this bug, tripping up TestCSVImportCanBeResumed. Release note: None
|
This change is |
pbardea
approved these changes
Jan 19, 2021
|
Thanks! |
|
TFTR! bors r+ |
|
Build failed: |
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...in the import processor. The contract of
RowSource.Nextrequiresthat at most one of the return values will be non-empty. This wasn't the
case here, and caused opaque failures in #58897. #58897 tries to enable
background tracing by default, which for us means that the trailing meta
can be non-empty (they'll contain span recordings). That behaviour ends
up tickling this bug, tripping up TestCSVImportCanBeResumed.
Release note: None