release-19.2: build: always specify PORTABLE=1 when building RocksDB #59018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
approved these changes
Jan 14, 2021
Something recently changed on the TC agents (presumably usage of a new machine type with a different CPU) so that using `-march=native` when building RocksDB causes AVX512 instructions to be used which are not present on roachprod machines. The result is that binaries built in this way will die with "illegal instruction". RocksDB has a mechanism to disable the use of `-march=native`: pass `PORTABLE=1` to the make command. We were already doing this for release builds. Now we're doing it for all builds. Fixes cockroachdb#58754 Release note: none
petermattis
force-pushed
the
pmattis/rocksdb-portable-19.2
branch
from
608abc6 to
61a8890
Compare
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something recently changed on the TC agents (presumably usage of a new
machine type with a different CPU) so that using
-march=nativewhenbuilding RocksDB causes AVX512 instructions to be used which are not
present on roachprod machines. The result is that binaries built in this
way will die with "illegal instruction". RocksDB has a mechanism to
disable the use of
-march=native: passPORTABLE=1to the makecommand. We were already doing this for release builds. Now we're doing
it for all builds.
Fixes #58754
Release note: none