release-20.2: util/log: stop syncing writes excessively #58996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Release note (cli change): Previously, for certain log files CockroachDB would both flush individual writes (i.e. propagate them from within the `cockroach` process to the OS) and also synchronize writes (i.e. ask the OS to confirm the log data was written to disk). The per-write synchronization part was unnecessary and, in fact, found to be possibly detrimental to performance and operating cost, so it was removed. Meanwhile, the log data continues to be flushed as previously, and CockroachDB also periodically (every 30s) request synchronization, also as previously.
knz
force-pushed
the
backport20.2-58995
branch
from
6dd938a to
46d6f16
Compare
itsbilal
approved these changes
Jan 19, 2021
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, 1 of 1 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @bdarnell)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #58995.
(Not a clean backport - I had to adapt 50% of the change. But the purpose and end result is the same.)
/cc @cockroachdb/release
Requested by @bdarnell