cli/demo: avoid login URL if insecure #58662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
otan
reviewed
Jan 10, 2021
| } | ||
| serverURL.Path = server.DemoLoginPath | ||
| serverURL.RawQuery = pwauth.Encode() | ||
| } | ||
| fmt.Fprintf(w, " (console) %s\n", serverURL) |
There was a problem hiding this comment.
i think this still prints the console link, do you mean avoid the link as in avoid printing username and password, or something else?
There was a problem hiding this comment.
Yes the URL must be printed in any case, what needs to be skipped is the autologin URL path.
otan
approved these changes
Jan 11, 2021
| serverURL.Path = server.DemoLoginPath | ||
| serverURL.RawQuery = pwauth.Encode() | ||
| if !demoCtx.insecure { | ||
| // Print node ID and console URL. Embed the autologin feature inside the URL. |
There was a problem hiding this comment.
maybe worth a comment about why we do not do this for insecure
|
TFYR bors r=otan |
|
Build failed: |
Release note: None
|
bors r=otan |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58661
NB: insecure is deprecated anyway #53404