release-20.2: sql: Fix privilege checks to consider direct/indirect roles #58512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rafiss
force-pushed
the
backport20.2-58254
branch
from
67f95cc to
059275c
Compare
angelapwen
reviewed
Jan 7, 2021
| statement ok | ||
| CREATE USER testuser2; | ||
| GRANT testuser TO testuser2; | ||
| GRANT ALL ON SCHEMA s TO testuser2 |
There was a problem hiding this comment.
Seems to be failing here
testdata/logic_test/privilege_builtins:1104:
expected success, but found
(3F000) unknown schema "s"
errors.go:60: in NewUndefinedSchemaError()
logic.go:2693:
testdata/logic_test/privilege_builtins:1104: error while processing
logic.go:2693: pq: unknown schema "s"
Does it need to be my_db.s instead of just s? I'm not sure why it fails in 20.2 but not in the original PR.
There was a problem hiding this comment.
ah i see... i had to remove that because this isn't (and won't be) backported to 20.2: #55647
hmm but i would have expected it to work since the current db is my_db... will investigate
There was a problem hiding this comment.
ah i see, probably because the user was switched to root.
Previously, privilege inquiry functions only looked for whether
the user passed in in the first argument or current user had
privileges on schemas, databases, tables, etc. with the built-ins
such as `has_schema_privileges`, which was incorrect. This change
makes sure that all roles the user is a direct or indirect member
of are checked for privileges as well.
Release note (bug fix): The has_${OBJECT}_privilege built-in methods
such as `has_schema_privilege` now additionally checks whether roles
the user is a direct or indirect member of also have privileges on
the object. Previously only one user was checked which was incorrect.
This bug has been present since version 2.0 but became more
prominent as of v20.2 when role-based access control was included in
CockroachDB Core.
rafiss
force-pushed
the
backport20.2-58254
branch
from
059275c to
4e2902c
Compare
angelapwen
approved these changes
Jan 7, 2021
|
yes i needed your review! thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #58254.
/cc @cockroachdb/release
Resolves #57621
Previously, privilege inquiry functions only looked for whether
the user passed in in the first argument or current user had
privileges on schemas, databases, tables, etc. with the built-ins
such as
has_schema_privileges, which was incorrect. This changemakes sure that all roles the user is a direct or indirect member
of are checked for privileges as well.
Release note (bug fix): The has_${OBJECT}_privilege built-in methods
such as
has_schema_privilegenow additionally checks whether rolesthe user is a direct or indirect member of also have privileges on
the object. Previously only one user was checked which was incorrect.
This bug has been present since version 2.0 but became more
prominent as of v20.2 when role-based access control was included in
CockroachDB Core.