bazel: generate colexecagg .eg.go files within the sandbox

[alan-mas]

Fixes #58421. For the go dependency changes, we've applied the same
treatment as 52c5f51.

Release note: None

[blathers-crl]

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

I was unable to automatically find a reviewer. You can try CCing one of the following members:

• A person you worked with closely on this PR.
• The person who created the ticket, or a CRDB organization member involved with the ticket (author, commenter, etc.).
• Join our community slack channel and ask on #contributors.
• Try find someone else from here.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.}

[cockroach-teamcity]

This change is 

[blathers-crl]

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.}

[rickystewart]

I'd prefer to just put all of this in pkg/sql/colexec/colexecagg/BUILD.bazel. eg_go_filegroup and gen_eg_go_rules are not reusable, so defining them as utility functions doesn't provide any value. Just makes things more complicated for no reason.

[alan-mas]

I am applying the same same treatment as 52c5f51. By pulling that inside pkg/sql/colexec/colexecagg/BUILD.bazel you mean follow the same logic that is already there in this PR or creating one gen_rule per file?

[rickystewart]

Can you just make this into a helper function? Something like:

def munge(s):
    if s.startswith('hash_'):
        return s[len('hash_'):].replace('.eg', '_tmpl')
    elif s.startswith('ordered_'):
        return s[len('ordered_'):].replace('.eg', '_tmpl')

munge('hash_any_not_null_agg.eg.go') => 'any_not_null_agg_tmpl.go'

Maybe something about Bazel is keeping you from doing this -- if so just let me know :)

[alan-mas]

I can give a try, actually I was just following the same logic applied before in older commits but I can try my luck with that change you are suggesting and see what's happening =)

Also, do you think is necessary to create a whole new function to only get the tmpl target name, for example this one: ('ordered_sum_int_agg.eg.go', 'sum_agg_tmpl.go') on that one I would need to create an specific elif for checking that case?

I think that it would make it a bit complex for something pretty straight forward (only gets names for the tmpl file) but I might be wrong and maybe it would make it easier to understand.

[irfansharif]

Thanks for the PR, LGTM. I've just amended the commit message and some comment slightly.

[irfansharif]

bors r+

[craig]

Build succeeded:

• GitHub CI (Cockroach)