Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: bump pebble to 97dabc1c2 #58468

Merged
merged 1 commit into from
Jan 6, 2021
Merged

vendor: bump pebble to 97dabc1c2 #58468

merged 1 commit into from
Jan 6, 2021

Conversation

dt
Copy link
Member

@dt dt commented Jan 5, 2021 •
edited
Loading

Upstream changes:

vfs,sstable: split out subset of vfs.File used for reading
docs: add a couple benchmark annotations
db: use uint64 for batch's memTableSize
sstable: add xxhash64 checksum support
sstable: Add ChecksumType to API
db: add an Iterator.Clone to iterate over the same db state

Release note: none.

@dt dt requested a review from itsbilal January 5, 2021 22:15
@cockroach-teamcity
Copy link
Member

This change is Reviewable

itsbilal
itsbilal approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@itsbilal itsbilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@dt
Copy link
Member Author

dt commented Jan 6, 2021

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Jan 6, 2021

Build succeeded:

@craig craig bot merged commit d87fa94 into cockroachdb:master Jan 6, 2021
@dt dt deleted the bump-pebble branch January 6, 2021 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsbilal itsbilal itsbilal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dt @cockroach-teamcity @itsbilal