demo: fix --global option #58466
demo: fix --global option #58466
Conversation
|
This change is |
|
Still no tests for this, sorry. |
There was a problem hiding this comment.
Nice! Now that we handle the ArtificialLatencyMap knob in grpcDialOptions, do we still need to also handle the knob in grpcDialRaw? Seems like the latter calls the former.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @ajstorm and @nvanbenschoten)
|
Tests?! Rename https://github.com/cockroachdb/cockroach/blob/master/pkg/cli/interactive_tests/test_demo_global.tcl.disabled to |
There was a problem hiding this comment.
I'm with Nathan - Nice!
Any chance you could add this to your PR? I wasn't able to test with the --global flag when I built add node, and realized in testing your change that the error message doesn't print out correctly.
index bebc3b0abf..27785de1b7 100644
--- a/pkg/cli/sql.go
+++ b/pkg/cli/sql.go
@@ -562,7 +562,7 @@ func (c *cliState) handleDemoAddNode(cmd []string, nextState, errState cliStateE
}
if demoCtx.simulateLatency {
- fmt.Printf("add command is not supported in --global configurations")
+ fmt.Printf("add command is not supported in --global configurations\n")
return nextState
}```Reviewable status:
The --global option broke somewhere during the 20.2 cycle. This patch revives it. --global simulates geo-latencies between nodes. Best used with `--global --geo-partitioned-replicas`. Release note (cli change): fix cockroach demo --global from crashing with "didn't get expected magic bytes header".
Release note: None
|
Build failed: |
|
bors r+ |
|
Build failed: |
|
that's a flake bors r+ |
|
Build succeeded: |
The --global option broke somewhere during the 20.2 cycle. This patch
revives it. --global simulates geo-latencies between nodes. Best used
with
--global --geo-partitioned-replicas.Release note (cli change): fix cockroach demo --global from crashing
with "didn't get expected magic bytes header".