tracing: remove tracing.AnnotateTrace #58432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
knz
reviewed
Jan 5, 2021
There was a problem hiding this comment.
I don't have an opinion either way, but I vaguely recall that @andreimatei has one. Andrei, what do you think?
Reviewed 13 of 13 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @tbg)
tbg
approved these changes
Jan 5, 2021
This code seems to have died years ago. Release note: None
irfansharif
force-pushed
the
210104.del-AnnotateTrace
branch
from
8f8bc95 to
838fa0c
Compare
|
bors r=tbg |
|
Build succeeded: |
|
I never really knew what this annotation did to the execution tracer... But it would have been nice for this commit message to say it. Tobi, do you know? |
|
I think it "segmented" the goroutine's trace in the output, so that you could tell when the call to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code seems to have died years ago.
Release note: None