pgwire: new env var COCKROACH_ALWAYS_LOG_AUTHN_EVENTS
#58379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for a new env var `COCKROACH_ALWAYS_LOG_AUTHN_EVENTS`. When set to a true-like value, it overrides the `server.auth_log.sql_sessions.enabled` cluster setting and unconditionally enables logging of authentication events. This is a temporary stop-gap so that it becomes possible to log authentication events in SQL pods for multi-tenant deployments. This stop-gap can be removed when multi-tenant CockroachDB learns to support cluster settings. Release note: None
|
This change is |
bdarnell
approved these changes
Jan 6, 2021
|
thanks bors r=bdarnell |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested by @logston . Intended for back-port to v20.2.
This commit adds support for a new env var
COCKROACH_ALWAYS_LOG_AUTHN_EVENTS. When set to a true-like value, itoverrides the
server.auth_log.sql_sessions.enabledcluster settingand unconditionally enables logging of authentication events.
This is a temporary stop-gap so that it becomes possible to log
authentication events in SQL pods for multi-tenant deployments. This
stop-gap can be removed when multi-tenant CockroachDB learns to
support cluster settings.
Release note: None