opt: add upsert checks for unique constraints #58301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds checks for unique constraints when planning upserts in the optimizer. This commit also includes a number of execbuilder and logic tests for upsert uniqueness checks. There is no release note since these checks are still gated behind the experimental_enable_unique_without_index_constraints session variable. Informs cockroachdb#41535 Release note: None
|
This change is |
RaduBerinde
approved these changes
Dec 28, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @mgartner and @RaduBerinde)
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds checks for unique constraints when planning upserts
in the optimizer. This commit also includes a number of
execbuilderand logic tests for upsert uniqueness checks.
There is no release note since these checks are still gated behind the
experimental_enable_unique_without_index_constraintssession variable.Informs #41535
Release note: None