roachtest: improve sqlsmith #58249
Merged
roachtest: improve sqlsmith #58249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Friendly ping @jordanlewis |
We need to delay the panic injection until after the smither is created because some queries are run during its instantiation. Release note: None
This commit temporarily skips failing `sqlsmith` roachtest on `internal error: invalid index` errors which are due to issues with subqueries (cockroachdb#39433) in order to reduce the noise. Release note: None
jordanlewis
approved these changes
Dec 28, 2020
yuzefovich
changed the title
|
No worries - in the first cut I didn't delay it enough. I also just added another commit to remove the noise. PTAL. |
jordanlewis
approved these changes
Dec 28, 2020
|
TFTR! bors r+ |
|
Build failed: |
|
Unrelated flake. bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
roachtest: delay panic injection in sqlsmith
We need to delay the panic injection until after the smither is created
because some queries are run during its instantiation.
Fixes: #58235.
Release note: None
roachtest: ignore a known issue in sqlsmith
This commit temporarily skips failing
sqlsmithroachtest oninternal error: invalid indexerrors which are due to issues with subqueries(#39433) in order to reduce the noise.
Release note: None