Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: use equalities to constrain inverted join prefix columns #58222

Merged
merged 1 commit into from
Dec 30, 2020
Merged

opt: use equalities to constrain inverted join prefix columns #58222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 28 additions & 12 deletions pkg/sql/opt/xform/join_funcs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,10 +470,24 @@ func (c *CustomFuncs) GenerateInvertedJoins(
inputCols := input.Relational().OutputCols
var pkCols opt.ColList

eqColsCalculated := false
var leftEqCols opt.ColList
var rightEqCols opt.ColList
var rightSideCols opt.ColList

var iter scanIndexIter
iter.Init(c.e.mem, &c.im, scanPrivate, on, rejectNonInvertedIndexes)
iter.ForEach(func(index cat.Index, on memo.FiltersExpr, indexCols opt.ColSet, isCovering bool) {
invertedJoin := memo.InvertedJoinExpr{Input: input}
numPrefixCols := index.NonInvertedPrefixColumnCount()

// Only calculate the left and right equality columns if there is a
// multi-column inverted index.
if numPrefixCols > 0 && !eqColsCalculated {
inputProps := input.Relational()
leftEqCols, rightEqCols = memo.ExtractJoinEqualityColumns(inputProps.OutputCols, scanPrivate.Cols, on)
eqColsCalculated = true
}

// The non-inverted prefix columns of a multi-column inverted index must
// be constrained in order to perform an inverted join. We attempt to
Expand All @@ -482,12 +496,17 @@ func (c *CustomFuncs) GenerateInvertedJoins(
// InvertedJoin, similar to GenerateLookupJoins.
// TODO(mgartner): Try to constrain prefix columns with CHECK
// constraints and computed column expressions.
// TODO(mgartner): Try to constrain prefix columns via ON condition
// equalities to columns in the input expression.
var constFilters memo.FiltersExpr
for i, n := 0, index.NonInvertedPrefixColumnCount(); i < n; i++ {
for i := 0; i < numPrefixCols; i++ {
prefixCol := scanPrivate.Table.IndexColumnID(index, i)

// Check if prefixCol is constrained by an equality constraint.
if eqIdx, ok := rightEqCols.Find(prefixCol); ok {
invertedJoin.PrefixKeyCols = append(invertedJoin.PrefixKeyCols, leftEqCols[eqIdx])
rightSideCols = append(rightSideCols, prefixCol)
continue
}

// Try to constrain prefixCol to constant, non-ranging values.
foundVals, onIdx, ok := c.findJoinFilterConstants(on, prefixCol)
if !ok {
Expand All @@ -499,7 +518,7 @@ func (c *CustomFuncs) GenerateInvertedJoins(
// We will join these constant values with the input to make
// equality columns for the inverted join.
if constFilters == nil {
constFilters = make(memo.FiltersExpr, 0, n)
constFilters = make(memo.FiltersExpr, 0, numPrefixCols)
}

prefixColType := c.e.f.Metadata().ColumnMeta(prefixCol).Type
Expand All @@ -516,16 +535,13 @@ func (c *CustomFuncs) GenerateInvertedJoins(
constFilters = append(constFilters, on[onIdx])
}

// Remove the constant filters that constrain the prefix columns from
// the on condition. Copy the filters to a new slice to avoid mutating
// the filters within iter.
if len(constFilters) > 0 {
onCopy := make(memo.FiltersExpr, len(on))
copy(onCopy, on)
on = onCopy
// Remove the redundant filters and update the ON condition if there are
// non-inverted prefix columns that have been constrained.
if len(rightSideCols) > 0 || len(constFilters) > 0 {
on = memo.ExtractRemainingJoinFilters(on, invertedJoin.PrefixKeyCols, rightSideCols)
on.RemoveCommonFilters(constFilters)
invertedJoin.ConstFilters = constFilters
}
invertedJoin.ConstFilters = constFilters

// Check whether the filter can constrain the inverted column.
invertedExpr := invertedidx.TryJoinInvertedIndex(
Expand Down
Loading