logictest: fix upsert test #58156
Merged
logictest: fix upsert test #58156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The trace message appears to contain only a single line if an error occurs (all lines apart from the first one are not shown), so this commit adjusts `upsert` opt logic test accordingly. Release note: None
|
This change is |
mgartner
approved these changes
Dec 21, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rytaft)
|
TFTR! bors r+ |
|
Build failed: |
|
Seems like a timeout on bors r+ |
|
Build failed: |
|
Another timeout, let's give it another try. bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Dec 22, 2020
58156: logictest: fix upsert test r=yuzefovich a=yuzefovich The trace message appears to contain only a single line if an error occurs (all lines apart from the first one are not shown), so this commit adjusts `upsert` opt logic test accordingly. Fixes: #58158. Release note: None Co-authored-by: Yahor Yuzefovich <[email protected]>
|
Build failed: |
|
LGTM. Looks like another flake, I'll try again while I'm here bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Dec 22, 2020
58110: opt: add OptionalColList type r=RaduBerinde a=RaduBerinde I am open to better suggestions for the name. #### opt: change ColSetToList() func to a ToList() method Release note: None #### opt: add OptionalColList type For mutations, we use ColLists that map 1-to-1 to table columns, and where some of the entries in the list can be 0. This is really meant to represent a mapping of columns and it is an abuse of the ColList type (which is supposed to be a simple list of columns). We add a separate OptionalColList type which has the desired semantics. This helps clarify things a bit (in particular it is now obvious which of the lists are "real" lists and which are "mappings"). It will also allow a different ToSet() method which makes sense for this structure (i.e. doesn't put 0 in the set). Release note: None 58156: logictest: fix upsert test r=RaduBerinde a=yuzefovich The trace message appears to contain only a single line if an error occurs (all lines apart from the first one are not shown), so this commit adjusts `upsert` opt logic test accordingly. Fixes: #58158. Release note: None Co-authored-by: Radu Berinde <[email protected]> Co-authored-by: Yahor Yuzefovich <[email protected]>
|
Build failed (retrying...): |
|
bors r+ |
|
Already running a review |
|
Oh, didn't realize it was in the queue already. |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trace message appears to contain only a single line if an error
occurs (all lines apart from the first one are not shown), so this
commit adjusts
upsertopt logic test accordingly.Fixes: #58158.
Release note: None