Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authors: added lukens@ to authors #58144

Merged
merged 1 commit into from
Jan 11, 2021
Merged

authors: added lukens@ to authors #58144

merged 1 commit into from
Jan 11, 2021

Conversation

Lukens4242
Copy link
Contributor

Tagging @irfansharif

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Dec 21, 2020

CLA assistant check
All committers have signed the CLA.

@blathers-crl
Copy link

blathers-crl bot commented Dec 21, 2020

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

Before a member of our team reviews your PR, I have some potential action items for you:

  • We notice you have more than one commit in your PR. We try break logical changes into separate commits, but commits such as "fix typo" or "address review commits" should be squashed into one commit and pushed with --force
  • When CI has completed, please ensure no errors have appeared.

I was unable to automatically find a reviewer. You can try CCing one of the following members:

  • A person you worked with closely on this PR.
  • The person who created the ticket, or a CRDB organization member involved with the ticket (author, commenter, etc.).
  • Join our community slack channel and ask on #contributors.
  • Try find someone else from here.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added O-community Originated from the community X-blathers-untriaged blathers was unable to find an owner labels Dec 21, 2020
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl
Copy link

blathers-crl bot commented Dec 21, 2020

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

I was unable to automatically find a reviewer. You can try CCing one of the following members:

  • A person you worked with closely on this PR.
  • The person who created the ticket, or a CRDB organization member involved with the ticket (author, commenter, etc.).
  • Join our community slack channel and ask on #contributors.
  • Try find someone else from here.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@irfansharif irfansharif changed the title Authors: Added [email protected] to authors authors: added lukens@ to authors Dec 21, 2020
Copy link
Contributor

@irfansharif irfansharif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be sure to sign the CLA agreement, and "bors r+"-ing the PR once done.

@Lukens4242
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Dec 21, 2020

🔒 Permission denied

Existing reviewers: click here to make Lukens4242 a reviewer

@irfansharif
Copy link
Contributor

bors r+

@craig
Copy link
Contributor

craig bot commented Dec 21, 2020

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@craig
Copy link
Contributor

craig bot commented Dec 21, 2020

GitHub status checks took too long to complete, so bors is giving up. You can adjust bors configuration to have it wait longer if you like.

@otan
Copy link
Contributor

otan commented Jan 11, 2021

bors r+

@craig
Copy link
Contributor

craig bot commented Jan 11, 2021

Build succeeded:

@craig craig bot merged commit c5c26fa into cockroachdb:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-community Originated from the community X-blathers-untriaged blathers was unable to find an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants