-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: initial support for virtual columns #57803
Conversation
c4c0459
to
c5f97e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @ajwerner, @mgartner, and @rytaft)
pkg/sql/opt/exec/execbuilder/testdata/virtual_columns, line 18 at r1 (raw file):
├── tableoid oid [hidden] [system] ├── FAMILY fam_0_b (b) ├── FAMILY fam_1_a_v (a, v)
Hm, I think virtual column should not be part of any column family. I'll fix that.
c5f97e7
to
2794f69
Compare
Added logic to disallow virtual columns from being part of column families; and added validation logic for the Virtual field. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was straightforward. Is there anything that needs to be done to use these in indexes, constraints, etc? If they would work, might be nice to add some testing, otherwise, might be nice to put up some gating.
Reviewed 9 of 13 files at r1, 8 of 9 files at r2.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @ajwerner, @mgartner, and @rytaft)
Yeah, quite a bit needs to be done, especially for indexes. I'm keeping a checklist in #57608. For now, we just have this one big gate. We'll consider gating more specific things when we get further along. |
This change adds very basic support for virtual columns to the non-test descriptors and catalog. This is gated behind an experimental session setting. Release note: None
2794f69
to
09fd267
Compare
Fixed and added some ValidateTableDescriptor tests. |
bors r+ |
Build succeeded: |
This change adds very basic support for virtual columns to the
non-test descriptors and catalog. This is gated behind an experimental
session setting.
Informs #57608.
Release note: None