ui: fix Download icon rendering on DiagnosticsView component #57776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
nathanstilwell
approved these changes
Dec 10, 2020
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @dhartunian and @elkmaster)
vladlos
approved these changes
Jan 5, 2021
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:
koorosh
force-pushed
the
fix-diagnostics-view-icon-render
branch
from
561180e to
a48073e
Compare
Previously (with some regression changes), an icon on Statement Diagnostics view wasn't rendered and instead base64 encoded string was shown. This fix introduces two kinds of changes: - Reused Download icon from `ui-components` package so it is renders properly - styles for `Anchor` and `Button` components are extended with `fill` attribute with the same values as for `color` attribute. It allows nested SVG elements (icons) to inherit proper colors even when link or button are hovered or disabled. Release note (ui change): fixes corrupted icon rendering on Statement Details page > Diagnostics tab
koorosh
force-pushed
the
fix-diagnostics-view-icon-render
branch
from
a48073e to
b03b370
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #57698
Previously (with some regression changes), an icon on Statement
Diagnostics view wasn't rendered and instead base64 encoded string
was shown.
This fix introduces two kinds of changes:
ui-componentspackage so it is rendersproperly
AnchorandButtoncomponents are extended withfillattribute with the same values as for
colorattribute. It allowsnested SVG elements (icons) to inherit proper colors even when link or button
are hovered or disabled.
Release note (ui change): fixes corrupted icon rendering on Statement
Details page > Diagnostics tab
Before:
After:
